Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/host-item): display warning when HVM disabled #6834

Merged
merged 4 commits into from
May 16, 2023
Merged

feat(xo-web/host-item): display warning when HVM disabled #6834

merged 4 commits into from
May 16, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented May 15, 2023 •
edited

Fixes #6823

Screenshot

Capture d’écran de 2023-05-15 16-08-42

Description

Displays a warning in the Home/Host view for hosts with HVM disabled.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this May 15, 2023
@MathieuRA MathieuRA requested a review from ggunullu May 15, 2023 14:20
@MathieuRA @ggunullu
Update packages/xo-web/src/common/intl/messages.js
43f3e90 
Co-authored-by: Gabriel Gunullu <64731573+ggunullu@users.noreply.github.com>
@MathieuRA MathieuRA requested a review from ggunullu May 15, 2023 15:08
@MathieuRA MathieuRA requested a review from julien-f May 16, 2023 12:29
@julien-f julien-f changed the title feat(xo-web/host-item): Display warning for host with HVM disabled feat(xo-web/host-item): display warning for when HVM disabled May 16, 2023
@julien-f julien-f merged commit 17cb59b into master May 16, 2023
1 check passed
@julien-f julien-f deleted the host-warning-hvm branch May 16, 2023 12:58
@julien-f julien-f changed the title feat(xo-web/host-item): display warning for when HVM disabled feat(xo-web/host-item): display warning when HVM disabled May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggunullu ggunullu ggunullu approved these changes

@julien-f julien-f Awaiting requested review from julien-f

Assignees

@MathieuRA MathieuRA

Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a warning if HVM is not enabled
3 participants
@MathieuRA @ggunullu @julien-f