Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@xen-orchestra/backups): use parallel reading whith NBD + blocks to only one remote #6840

Closed
wants to merge 1 commit into from

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 17, 2023

Description

PR #6716 removed the parallel reading in favor a widespread use of NBD and unique reading

this PR make it possible to use parallel reading given theses prequisites :

  • delta backup job
  • only one remote AND it is store vhd in block
  • no replication

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp
Copy link
Collaborator Author

no real performance gain after tests

@fbeauchamp fbeauchamp closed this Jul 5, 2023
@olivierlambert
Copy link
Member

Darn, so we don't use NBD read on multiple blocks at the same time anymore? I'm surprised there's no diff vs our initial tests, but I might be confused about the purpose of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants