Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node-vsphere-soap): security improvements #6859

Merged
merged 6 commits into from Jun 19, 2023
Merged

feat(node-vsphere-soap): security improvements #6859

merged 6 commits into from Jun 19, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 24, 2023 •
edited

Description

  • lib depend on an older version of lodash with a security alert
  • lib use a global flag to handle self signed certificate, lowering global security of the while node process

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp force-pushed the feat_fork_vsphere_soap branch 4 times, most recently from dd66c5e to e09e11b Compare June 12, 2023 12:02
@fbeauchamp fbeauchamp changed the title feat(node-vsphere-soap): update code feat(node-vsphere-soap): security improvments Jun 12, 2023
@fbeauchamp fbeauchamp changed the title feat(node-vsphere-soap): security improvments feat(node-vsphere-soap): security improvements Jun 12, 2023
@fbeauchamp fbeauchamp marked this pull request as ready for review June 12, 2023 12:11
@fbeauchamp fbeauchamp requested a review from julien-f June 12, 2023 12:14
@julien-f julien-f force-pushed the feat_fork_vsphere_soap branch 4 times, most recently from 7266868 to b3d4df7 Compare June 13, 2023 09:48
@julien-f julien-f removed their request for review June 13, 2023 20:46
@fbeauchamp fbeauchamp requested a review from julien-f June 19, 2023 06:31
@julien-f julien-f merged commit 4c05064 into master Jun 19, 2023
1 check passed
@julien-f julien-f deleted the feat_fork_vsphere_soap branch June 19, 2023 07:31
This was referenced Jun 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbeauchamp @julien-f