Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backups): handles task end in CR without health check #6866

Merged
merged 7 commits into from
May 30, 2023
Merged

fix(backups): handles task end in CR without health check #6866

merged 7 commits into from
May 30, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 29, 2023 •
edited

Description

from https://xcp-ng.org/forum/topic/7376/continuous-replication-storage-issue/8

should be reworked/rechecked after merging mirror backups

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@julien-f julien-f changed the title fix(backups): handles task end in CR without healthcheck fix(backups): handles task end in CR without health check May 30, 2023
@fbeauchamp fbeauchamp marked this pull request as ready for review May 30, 2023 11:48
@fbeauchamp fbeauchamp marked this pull request as draft May 30, 2023 11:52
@fbeauchamp fbeauchamp force-pushed the fix_cr_task_without_healthcheck branch 2 times, most recently from f8c5033 to 3ac1637 Compare May 30, 2023 11:57
@fbeauchamp
Copy link
Collaborator Author

fbeauchamp commented May 30, 2023 •
edited

tests
incremental CR alone
image

incremental CR + healthcheck
image

full CR alone
image

full CR + healthcheck
image

@fbeauchamp fbeauchamp marked this pull request as ready for review May 30, 2023 13:46
@fbeauchamp fbeauchamp force-pushed the fix_cr_task_without_healthcheck branch from 3ac1637 to fec0360 Compare May 30, 2023 13:46
@fbeauchamp fbeauchamp requested a review from julien-f May 30, 2023 13:54
@julien-f julien-f merged commit 3f316fc into master May 30, 2023
1 check passed
@julien-f julien-f deleted the fix_cr_task_without_healthcheck branch May 30, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbeauchamp @julien-f