Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web): enhance RRD stats #6903

Merged
merged 11 commits into from
Jun 28, 2023
Merged

fix(xo-web): enhance RRD stats #6903

merged 11 commits into from
Jun 28, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jun 16, 2023 •
edited

Description

  • fix infinite requests
  • avoid duplicate requests

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp
Copy link
Collaborator

after measure : computing the stat of a VM from the full host json in xo-lab take 0-1ms on my machine

@MathieuRA MathieuRA marked this pull request as ready for review June 26, 2023 08:43
@MathieuRA MathieuRA changed the title Wip: fix(xo-web/xo-server): xapi-stats debug fix(xo-web/xo-server): xapi-stats debug Jun 26, 2023
@MathieuRA MathieuRA changed the title fix(xo-web/xo-server): xapi-stats debug fix(xo-web/xo-server): enhance RRD stats Jun 26, 2023
@MathieuRA MathieuRA requested review from pdonias and julien-f and removed request for pdonias and julien-f June 26, 2023 12:22
@MathieuRA MathieuRA requested review from pdonias and julien-f and removed request for pdonias June 26, 2023 12:48
pdonias
pdonias requested changes Jun 27, 2023
View reviewed changes
packages/xo-web/src/xo-app/host/tab-stats.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/host/tab-stats.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias June 28, 2023 08:25
@MathieuRA MathieuRA removed the request for review from julien-f June 28, 2023 12:31
@fbeauchamp fbeauchamp mentioned this pull request Jun 28, 2023
Merged
@MathieuRA MathieuRA changed the title fix(xo-web/xo-server): enhance RRD stats fix(xo-web): enhance RRD stats Jun 28, 2023
@pdonias pdonias merged commit 38439cb into master Jun 28, 2023
1 check passed
@pdonias pdonias deleted the xapiStats-debug branch June 28, 2023 13:17
julien-f pushed a commit that referenced this pull request Jul 18, 2023
@fbeauchamp
fix(xo-server/xapi-stats): simplify caching (#6920)
8347ac6 
Following #6903

- change cache system per object => per host
- update cache at the beginning of the query to handle race conditions leading to duplicate requests
- remove concurrency limit (was leading to a huge backlog of queries, and response handling is quite fast)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

Assignees

@fbeauchamp fbeauchamp

@MathieuRA MathieuRA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MathieuRA @fbeauchamp @pdonias @julien-f