Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(read-chunk/readChunkStrict): attach read chunk to error if small text #6940

Merged
merged 3 commits into from
Jul 20, 2023
Merged

feat(read-chunk/readChunkStrict): attach read chunk to error if small text #6940

merged 3 commits into from
Jul 20, 2023

Conversation

fbeauchamp
Copy link
Collaborator

Description

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp marked this pull request as ready for review July 12, 2023 13:22
@fbeauchamp fbeauchamp requested a review from julien-f July 12, 2023 13:22
julien-f
julien-f requested changes Jul 13, 2023
View reviewed changes
@vates/read-chunk/index.js Outdated Show resolved Hide resolved
@vates/read-chunk/index.js Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp requested a review from julien-f July 20, 2023 13:27
@julien-f julien-f changed the title feat(@vates/readchunk): show the content received when stream is too short feat(@vates/read-chunk): show the content received when stream is too short Jul 20, 2023
@julien-f julien-f changed the title feat(@vates/read-chunk): show the content received when stream is too short feat(read-chunk/readChunkStrict): attach read chunk to error if small text Jul 20, 2023
@julien-f julien-f merged commit 1c23bd5 into master Jul 20, 2023
1 check passed
@julien-f julien-f deleted the feat_readchunk_error branch July 20, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbeauchamp @julien-f