Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs/s3): retry on failures #6966

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat(fs/s3): retry on failures #6966

merged 1 commit into from
Aug 31, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Aug 2, 2023

Description

any file level operation can fail in unpredictable ways, we retry safer function when any error not in safe list occurs. For now we only implement this on S3 remotes

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp
Copy link
Collaborator Author

fbeauchamp commented Aug 4, 2023

tested by adding

if(Math.random() > 0.8){
  throw new Error('nope')
}

in local.js protected method: restore still work ( use listing, readfile, ...)

@fbeauchamp fbeauchamp force-pushed the fs_retry branch 2 times, most recently from e37f8bd to 2336137 Compare August 8, 2023 09:53
@fbeauchamp fbeauchamp marked this pull request as ready for review August 8, 2023 09:55
@julien-f julien-f self-requested a review August 29, 2023 09:54
@julien-f julien-f changed the title feat(fs): retry on fail feat(fs/s3): retry on failures Aug 31, 2023
@julien-f julien-f merged commit 6a0df7a into master Aug 31, 2023
1 check passed
@julien-f julien-f deleted the fs_retry branch August 31, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants