Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netbox: misc improvements #6989

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Netbox: misc improvements #6989

merged 5 commits into from
Aug 30, 2023

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Aug 17, 2023

Fixes #6978

DO NOT SQUASH!

Description

Review commit by commit.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@pdonias pdonias requested a review from MathieuRA August 17, 2023 16:24
@pdonias pdonias marked this pull request as ready for review August 17, 2023 16:25
@pdonias pdonias changed the title Misc improvements Netbox: misc improvements Aug 18, 2023
MathieuRA
MathieuRA requested changes Aug 24, 2023
View reviewed changes
packages/xo-server-netbox/src/index.js Outdated Show resolved Hide resolved
packages/xo-server-netbox/src/index.js Show resolved Hide resolved
@pdonias pdonias requested a review from MathieuRA August 28, 2023 07:46
@pdonias pdonias requested a review from julien-f August 30, 2023 14:57
@julien-f julien-f merged commit 8ebc0db into master Aug 30, 2023
1 check passed
@julien-f julien-f deleted the pierre-netbox-misc branch August 30, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuRA MathieuRA MathieuRA approved these changes

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XO Netbox plugin overrides primary IP (in Netbox) on sync when first VM interface unassigned
3 participants
@pdonias @julien-f @MathieuRA