Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backups): expose NBD settings per backup #6995

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Aug 21, 2023

Description

NBD can only be enabler network wide, and only by modifying the config file.
This PR add a setting in the advanced tab of incremental backup to allow the users to set it from the UI

image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp marked this pull request as ready for review August 21, 2023 14:30
MathieuRA

This comment was marked as resolved.

@MathieuRA MathieuRA requested a review from pdonias August 23, 2023 08:44
@julien-f julien-f self-requested a review August 29, 2023 09:51
@pdonias pdonias requested a review from MathieuRA August 29, 2023 13:03
@julien-f julien-f force-pushed the feat_nbd_job_settings branch 2 times, most recently from 268c55e to 254d736 Compare August 30, 2023 14:56
@julien-f julien-f merged commit 311b420 into master Aug 30, 2023
1 check passed
@julien-f julien-f deleted the feat_nbd_job_settings branch August 30, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants