feat(netbox): don't delete VMs and interfaces that don't have a UUID #7008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajaa-BARHTAOUI
approved these changes
Sep 7, 2023
MathieuRA
reviewed
Sep 8, 2023
See https://xcp-ng.org/forum/topic/7639 In an effort of not deleting or overwriting useful data that has been added manually by the user, this reverts the feature of deleting VMs and interfaces that are not bound to an XO object via their custom field UUID. Such objects: - shouldn't exist in normal use cases anyway - aren't an issue for the Netbox sync - are easy to clean manually
|
I was thinking no at first but actually, it's visible by users so I'm going to add it. |
pdonias
force-pushed
the
pierre-netbox-no-cleanup
branch
from
c165aa2
to
9be24ae
Compare
MathieuRA
requested changes
Sep 8, 2023
Co-authored-by: Mathieu <70369997+MathieuRA@users.noreply.github.com>
MathieuRA
approved these changes
Sep 8, 2023
ByScripts
pushed a commit
that referenced
this pull request
Sep 14, 2023
…7008) See https://xcp-ng.org/forum/topic/7639 In an effort of not deleting or overwriting useful data that has been added manually by the user, this reverts the feature of deleting VMs and interfaces that are not bound to an XO object via their custom field UUID. Such objects: - shouldn't exist in normal use cases anyway - aren't an issue for the Netbox sync - are easy to clean manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://xcp-ng.org/forum/topic/7639
Description
In an effort of not deleting or overwriting useful data that has been added manually by the user, this reverts the feature of deleting VMs and interfaces that are not bound to an XO object via their custom field UUID. Such objects:
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md