-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many fixes and improvements on Jobs/Overview #7034
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
force-pushed
the
fix-job-schedule
branch
4 times, most recently
from
September 12, 2023 12:46
d030e6b
to
704cf03
Compare
MathieuRA
approved these changes
Sep 13, 2023
pdonias
requested changes
Sep 14, 2023
pdonias
approved these changes
Sep 15, 2023
@julien-f Can you rebase and non-squash merge? |
Fixes #6968 The schedules did not appear if the jobs subscription triggered after the schedules one. The logic has been moved to a computed depending on both subscriptions.
julien-f
force-pushed
the
fix-job-schedule
branch
from
September 15, 2023 09:04
a870ae8
to
1b582a2
Compare
julien-f
force-pushed
the
fix-job-schedule
branch
from
September 15, 2023 09:05
1b582a2
to
f3610b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by commits and DO NOT SQUASH.
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md