Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/SelectPif): show network name #7081

Merged
merged 3 commits into from
Oct 10, 2023
Merged

feat(xo-web/SelectPif): show network name #7081

merged 3 commits into from
Oct 10, 2023

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Oct 9, 2023

See Zammad#17381

Description

Show network name in PIF selectors as it can help differentiate PIFs that have the same device/deviceName.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@pdonias pdonias requested a review from MathieuRA October 9, 2023 13:50
@pdonias pdonias merged commit 99e3622 into master Oct 10, 2023
1 check passed
@pdonias pdonias deleted the pierre-pif-show-network branch October 10, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pdonias @julien-f @MathieuRA