Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server-usage-report): use @xen-orchestra/log to log errors #7096

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Oct 16, 2023

Fixes Zammad#14579
Fixes Zammad#18183

Description

Better handles error objects with a circular structure and avoids "Converting circular structure to JSON" error on stringify

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Fixes Zammad#14579
Fixes Zammad#18183

Better handles error objects with a circular structure and avoids "Converting
circular structure to JSON" error on stringify
@pdonias pdonias requested a review from julien-f October 16, 2023 08:01
@julien-f julien-f merged commit 04dfd9a into master Oct 16, 2023
1 check passed
@julien-f julien-f deleted the pierre-fix-usage-report-circular branch October 16, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants