Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/New network): don't show PIFs that belong to a bond #7136

Merged
merged 4 commits into from
Oct 30, 2023
Merged

feat(xo-web/New network): don't show PIFs that belong to a bond #7136

merged 4 commits into from
Oct 30, 2023

Conversation

Pizzosaure
Copy link
Contributor

Description

Condition added to check if PIF is a bond slave or a bond master

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

pdonias
pdonias requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add at least the names of the packages (xo-web in this case) in the commit message's context: feat(xo-web/New network): don't show PIFs that belong to a bond
  • Add an entry to the Changelog

@Pizzosaure Pizzosaure changed the title feat(xo-app/PIFs): check if PIF is bondSlave or bondMaster feat(xo-web/New network): don't show PIFs that belong to a bond Oct 30, 2023
pdonias
pdonias requested changes Oct 30, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pdonias
pdonias requested changes Oct 30, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@pdonias pdonias merged commit dbdc5f3 into master Oct 30, 2023
1 check passed
@pdonias pdonias deleted the checkIfBondMaster branch October 30, 2023 14:47
@pdonias pdonias mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pizzosaure @pdonias