Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fs): handle object storage server not implementing Object Lock #7157

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix(fs): handle object storage server not implementing Object Lock #7157

merged 2 commits into from
Nov 6, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Nov 6, 2023 •
edited

Description

introduced by #7086
Some S3 server implementation does not implement object lock

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp marked this pull request as ready for review November 6, 2023 09:16
@fbeauchamp fbeauchamp changed the title fix(@xen-orchestra/fs): handle object storage server not implementing Object lock fix(@xen-orchestra/fs): handle object storage server not implementing Object Lock Nov 6, 2023
julien-f
julien-f reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts and I'll merge.

@julien-f julien-f changed the title fix(@xen-orchestra/fs): handle object storage server not implementing Object Lock fix(fs): handle object storage server not implementing Object Lock Nov 6, 2023
@julien-f julien-f merged commit 2bfdb60 into master Nov 6, 2023
1 check passed
@julien-f julien-f deleted the fix_s3_notimplemented branch November 6, 2023 16:18
@fbeauchamp fbeauchamp mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbeauchamp @julien-f @MathieuRA