Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/console): add disabled console message #7161

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

Pizzosaure
Copy link
Contributor

@Pizzosaure Pizzosaure commented Nov 7, 2023

Description

Fixes #6319
Indicates the disabling of console view.
Screenshot from 2023-11-07 11-11-05

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-console.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-console.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to mark the issue #6319 as fixed by this PR in the PR description: Fixes #6319

@pdonias pdonias changed the title feat(xo-web/console): added deactivated console message feat(xo-web/console): add disabled console message Nov 21, 2023
@pdonias pdonias merged commit f3e0227 into master Nov 21, 2023
1 check passed
@pdonias pdonias deleted the consoleTabMessage branch November 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable console view for a VM with other-config:disable_pv_vnc=1
4 participants