Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack plugin update #7220

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Slack plugin update #7220

merged 6 commits into from
Dec 18, 2023

Conversation

b-Nollet
Copy link
Contributor

@b-Nollet b-Nollet commented Dec 5, 2023

Description

Changing the package used for slack webhooks, to ensure compatibility with slack-compatible services like discord or mattermost. Fixes #7130

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@b-Nollet
Copy link
Contributor Author

b-Nollet commented Dec 5, 2023

I created test webhooks for slack and discord, so if you want to test while reviewing this PR, just ask me for the links.

@julien-f julien-f self-requested a review December 6, 2023 08:48
@julien-f
Copy link
Member

Please rebase and add me as a reviewer.

@julien-f julien-f merged commit e361841 into master Dec 18, 2023
1 check passed
@julien-f julien-f deleted the slack-plugin-update branch December 18, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants