Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(incremental_backups): explain NBD #7240

Merged
merged 8 commits into from
Dec 18, 2023
Merged

Conversation

ManonMercier
Copy link
Contributor

Adding a section about NBD-enabled backups as discussed with Yannick and Florent. See PR-7239 for the screenshots.

Description

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Adding a section about NBD-enabled backups.
Copy link
Contributor

@Fohdeesha Fohdeesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good already! nice!

docs/incremental_backups.md Outdated Show resolved Hide resolved
docs/incremental_backups.md Outdated Show resolved Hide resolved
docs/incremental_backups.md Show resolved Hide resolved
Manon Mercier and others added 2 commits December 18, 2023 10:07
Co-authored-by: Florent BEAUCHAMP <florent.beauchamp@vates.fr>
Co-authored-by: Florent BEAUCHAMP <florent.beauchamp@vates.fr>
Copy link
Contributor Author

@ManonMercier ManonMercier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed a couple of things and will ask Julien to review the whole PR.

docs/incremental_backups.md Outdated Show resolved Hide resolved
docs/incremental_backups.md Outdated Show resolved Hide resolved
@ManonMercier
Copy link
Contributor Author

Julien, could you please take a look at this PR and merge it (if everything looks good)?
We can also wait for Jon's return for him to do a last check on the English.

julien-f and others added 2 commits December 18, 2023 11:20
Co-authored-by: Manon Mercier <manon.mercier@vates.fr>
Co-authored-by: Manon Mercier <manon.mercier@vates.fr>
@julien-f julien-f changed the title Update incremental_backups.md chore(incremental_backups): explain NBD Dec 18, 2023
@julien-f julien-f changed the title chore(incremental_backups): explain NBD docs(incremental_backups): explain NBD Dec 18, 2023
@julien-f julien-f merged commit a0b50b4 into master Dec 18, 2023
1 check passed
@julien-f julien-f deleted the ManonMercier-patch-2 branch December 18, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants