Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/menu): do not subscribe to proxies if no permissions #7249

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

OlivierFL
Copy link
Contributor

Description

Menu : don't subscribe to proxies if user has not enough permissions

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@OlivierFL OlivierFL self-assigned this Dec 20, 2023
@OlivierFL OlivierFL force-pushed the xo5/proxies-subscription-permissions branch 2 times, most recently from bef5174 to 3e28dd1 Compare December 20, 2023 09:24
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@OlivierFL OlivierFL force-pushed the xo5/proxies-subscription-permissions branch from 3e28dd1 to db73ef9 Compare December 27, 2023 09:00
@OlivierFL OlivierFL changed the title fix(xo-web): do not subscribe to proxies if no permissions fix(xo-web/menu): do not subscribe to proxies if no permissions Dec 27, 2023
@OlivierFL OlivierFL force-pushed the xo5/proxies-subscription-permissions branch 2 times, most recently from 166c506 to 5b7e8ae Compare January 2, 2024 13:56
@OlivierFL OlivierFL force-pushed the xo5/proxies-subscription-permissions branch from 5b7e8ae to f80439b Compare January 3, 2024 17:14
@OlivierFL OlivierFL force-pushed the xo5/proxies-subscription-permissions branch from f80439b to b3fc5f6 Compare January 4, 2024 08:55
@julien-f julien-f merged commit 95492f6 into master Jan 4, 2024
1 check passed
@julien-f julien-f deleted the xo5/proxies-subscription-permissions branch January 4, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants