Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/tab-advanced): allow to update vm creator #7276

Merged
merged 10 commits into from Jan 19, 2024
Merged

feat(xo-web/tab-advanced): allow to update vm creator #7276

merged 10 commits into from Jan 19, 2024

Conversation

Pizzosaure
Copy link
Contributor

@Pizzosaure Pizzosaure commented Jan 3, 2024 •
edited by MathieuRA

Description

Related to forum#7313
Allow to update vm creator seen in general tab, feature added in advanced tab :
Screenshot from 2024-01-03 15-24-09

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

MathieuRA
MathieuRA requested changes Jan 3, 2024
View reviewed changes
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-objects.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/select-objects.js Outdated Show resolved Hide resolved
MathieuRA
MathieuRA requested changes Jan 5, 2024
View reviewed changes
Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add a reference to the forum thread in the PR description.

packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
@Pizzosaure Pizzosaure marked this pull request as ready for review January 8, 2024 09:12
@MathieuRA MathieuRA requested a review from pdonias January 8, 2024 09:15
@pdonias pdonias requested review from OlivierFL and removed request for pdonias January 15, 2024 08:30
@MathieuRA MathieuRA merged commit f024238 into master Jan 19, 2024
1 check passed
@MathieuRA MathieuRA deleted the updateVmCreator branch January 19, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierFL OlivierFL OlivierFL approved these changes

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pizzosaure @OlivierFL @MathieuRA