Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lite): upgrade deps + root eslint config #7292

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Conversation

ByScripts
Copy link
Contributor

@ByScripts ByScripts commented Jan 9, 2024

Description

1. Moved ESLint config to root

XO Lite now uses the root ESLint config, which has been extended for Vue/TS.

Files have been updated accordingly.

2. Reenabled Prettier

Root Prettier config is now applied to the Lite project.

Files have been updated accordingly.

3. Upgraded project deps.

Notable changes:

  • TypeScript 5.2 => 5.3
  • Vite 4.5 => 5.0
  • Vue 3.3 => 3.4

4. Updated scripts/release.mjs for better linting

This script was causing a lot of ESLint issues.

5. Added specific TS configuration for type-check

Before, the stories directory was completely exclude from TypeScript because it causes type check errors which can not be addressed for now.

A specific TS config file (tsconfig.type-check.ts) has been created to be used only with type-check so errors in these file will no longer be ignored by TS at build time. Only while type checking.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@ByScripts ByScripts self-assigned this Jan 9, 2024
.eslintrc.js Outdated Show resolved Hide resolved
@pdonias pdonias requested a review from julien-f January 15, 2024 08:26
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, try to split changes in commits (e.g. conf changes, dep updates, formatting), it makes it easier to pinpoint issues when investigating (e.g. git bisect).

@julien-f julien-f merged commit ea19b08 into master Jan 15, 2024
1 check passed
@julien-f julien-f deleted the lite/deps+root-eslint branch January 15, 2024 10:12
borzel pushed a commit to borzel/xen-orchestra that referenced this pull request Jan 17, 2024
borzel pushed a commit to borzel/xen-orchestra that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants