-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lite): upgrade deps + root eslint config #7292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
reviewed
Jan 10, 2024
pdonias
approved these changes
Jan 15, 2024
3c5c55f
to
b2d9b9b
Compare
julien-f
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, try to split changes in commits (e.g. conf changes, dep updates, formatting), it makes it easier to pinpoint issues when investigating (e.g. git bisect
).
borzel
pushed a commit
to borzel/xen-orchestra
that referenced
this pull request
Jan 17, 2024
borzel
pushed a commit
to borzel/xen-orchestra
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Moved ESLint config to root
XO Lite now uses the root ESLint config, which has been extended for Vue/TS.
Files have been updated accordingly.
2. Reenabled Prettier
Root Prettier config is now applied to the Lite project.
Files have been updated accordingly.
3. Upgraded project deps.
Notable changes:
4. Updated
scripts/release.mjs
for better lintingThis script was causing a lot of ESLint issues.
5. Added specific TS configuration for
type-check
Before, the
stories
directory was completely exclude from TypeScript because it causes type check errors which can not be addressed for now.A specific TS config file (
tsconfig.type-check.ts
) has been created to be used only withtype-check
so errors in these file will no longer be ignored by TS at build time. Only while type checking.Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md