Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/VM): ability to add custom notes #7322

Merged
merged 6 commits into from
Jan 26, 2024
Merged

feat(xo-web/VM): ability to add custom notes #7322

merged 6 commits into from
Jan 26, 2024

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Jan 18, 2024 •
edited

Fixes #5792

Screenshots

Capture_2024-01-25_12:02:11
Capture_2024-01-18_15:07:57

Description

Custom notes are stored in VM's other_config['xo:notes'].
Custom notes are displayed in VM's General tab and rendered with marked and sanitize-html.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

MathieuRA
MathieuRA requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ XSS injection is possible through the notes fields.
A user could steal cookies from an administrator session, for example:

Capture d’écran de 2024-01-23 15-58-50
Capture d’écran de 2024-01-23 15-56-26

packages/xo-web/src/common/xo/edit-vm-notes-modal/index.js Outdated Show resolved Hide resolved
julien-f
julien-f reviewed Jan 25, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@pdonias pdonias requested a review from julien-f January 25, 2024 10:49
@MathieuRA MathieuRA merged commit c250cd9 into master Jan 26, 2024
1 check passed
@MathieuRA MathieuRA deleted the pierre-vm-notes branch January 26, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f approved these changes

@OlivierFL OlivierFL OlivierFL approved these changes

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: Notes field for VM
4 participants
@pdonias @julien-f @OlivierFL @MathieuRA