Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fix on VM migration #7360

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Various fix on VM migration #7360

merged 3 commits into from
Mar 6, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Feb 6, 2024 •
edited

Description

See #7378

  • review by commits
  • do not squash

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Feb 6, 2024
@MathieuRA MathieuRA force-pushed the xo5/fix-bulk-migration branch 2 times, most recently from 7547932 to d98ee96 Compare February 6, 2024 15:55
fbeauchamp
fbeauchamp reviewed Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@fbeauchamp fbeauchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a lot things goiing on, and a lot of edge case, I think it could be a good idea to make some doc in the /docs folder, so taht this knowledge is shared

@MathieuRA MathieuRA mentioned this pull request Feb 13, 2024
Merged
pdonias pushed a commit that referenced this pull request Feb 23, 2024
@MathieuRA
feat(docs): add VM migration spec (#7378)
089704d 
See #7360
@MathieuRA MathieuRA force-pushed the xo5/fix-bulk-migration branch 3 times, most recently from 9bd5686 to e47e76c Compare February 28, 2024 14:31
@fbeauchamp fbeauchamp requested a review from julien-f March 1, 2024 10:17
julien-f
julien-f reviewed Mar 5, 2024
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from julien-f March 5, 2024 13:23
julien-f
julien-f approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rebase and merge 🙂

@MathieuRA MathieuRA merged commit 1ae7b1d into master Mar 6, 2024
1 check passed
@MathieuRA MathieuRA deleted the xo5/fix-bulk-migration branch March 6, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeauchamp fbeauchamp fbeauchamp approved these changes

@julien-f julien-f julien-f approved these changes

Assignees

@MathieuRA MathieuRA

Labels
type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MathieuRA @fbeauchamp @julien-f