Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/SR): show suspend VDIs VMs #7391

Merged
merged 8 commits into from
Feb 29, 2024
Merged

feat(xo-web/SR): show suspend VDIs VMs #7391

merged 8 commits into from
Feb 29, 2024

Conversation

Pizzosaure
Copy link
Contributor

@Pizzosaure Pizzosaure commented Feb 19, 2024

Description

Find out to which VM a suspend image belongs :
before
image
after
Screenshot from 2024-02-19 16-56-57

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@Pizzosaure Pizzosaure marked this pull request as ready for review February 19, 2024 16:07
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the change in the PR description or link to the feature request source to make sure the code changes match the expected behavior? :)

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
packages/xo-server/src/xapi-object-to-xo.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
@Pizzosaure Pizzosaure requested review from pdonias and MathieuRA and removed request for pdonias February 26, 2024 09:11
Copy link
Member

@MathieuRA MathieuRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget this comment

packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA removed the request for review from pdonias February 26, 2024 13:24
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/sr/tab-disks.js Outdated Show resolved Hide resolved
@pdonias pdonias changed the title feat(xo-web/storage): handle link to VM for suspend VDIs feat(xo-web/SR): show suspend VDIs VMs Feb 29, 2024
@pdonias pdonias merged commit 649c117 into master Feb 29, 2024
1 check passed
@pdonias pdonias deleted the linkSuspendedVdiToVm branch February 29, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants