Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/xo-server/VM): ability to attach PCIs to a VM #7464

Merged
merged 3 commits into from
Apr 29, 2024
Merged

feat(xo-web/xo-server/VM): ability to attach PCIs to a VM #7464

merged 3 commits into from
Apr 29, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Mar 12, 2024 •
edited

Screenshot

Capture d’écran de 2024-03-12 16-55-03

Description

Related to #7432

Can be tested on 172.16.211.11

Rebase on pci-api to have PCI API methods

Wait for #7444

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Mar 12, 2024
@Pizzosaure Pizzosaure requested a review from pdonias March 18, 2024 10:06
pdonias
pdonias requested changes Mar 19, 2024
View reviewed changes
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/pci-attach-modal.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias March 19, 2024 16:10
pdonias
pdonias requested changes Mar 21, 2024
View reviewed changes
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-advanced.js Outdated Show resolved Hide resolved
@pdonias pdonias requested a review from julien-f March 21, 2024 09:30
julien-f
julien-f reviewed Mar 21, 2024
View reviewed changes
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias April 2, 2024 08:05
@MathieuRA MathieuRA force-pushed the pci-attach branch 2 times, most recently from 56b70ad to 340668b Compare April 26, 2024 13:25
@MathieuRA MathieuRA changed the base branch from pci-features to master April 26, 2024 13:25
@MathieuRA MathieuRA marked this pull request as ready for review April 29, 2024 13:21
@MathieuRA MathieuRA merged commit 50938a3 into master Apr 29, 2024
1 check passed
@MathieuRA MathieuRA deleted the pci-attach branch April 29, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

@pdonias pdonias pdonias approved these changes

@Pizzosaure Pizzosaure Pizzosaure approved these changes

Assignees

@MathieuRA MathieuRA

Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MathieuRA @julien-f @pdonias @Pizzosaure