Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web): add OTP requires validation #7480

Merged
merged 5 commits into from
Mar 27, 2024
Merged

feat(xo-web): add OTP requires validation #7480

merged 5 commits into from
Mar 27, 2024

Conversation

julien-f
Copy link
Member

@julien-f julien-f commented Mar 19, 2024 •
edited

Description

This prevents users from forgetting to add OTP account in their application and thus being locked out from XO.

screenshot

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@julien-f julien-f marked this pull request as ready for review March 19, 2024 10:43
@julien-f julien-f requested a review from pdonias March 19, 2024 10:43
pdonias
pdonias requested changes Mar 21, 2024
View reviewed changes
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/user/otp.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/user/otp.js Outdated Show resolved Hide resolved
@pdonias pdonias requested a review from MathieuRA March 21, 2024 10:15
julien-f and others added 2 commits March 21, 2024 11:22
@julien-f @pdonias
Apply suggestions from code review
d13648b 
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
@julien-f
remove extra chars
569790d
@julien-f julien-f requested a review from MathieuRA March 25, 2024 09:32
@MathieuRA MathieuRA requested a review from pdonias March 25, 2024 18:03
@pdonias pdonias changed the title Enabling OTP requires entering one-time password to validate setup feat(xo-web): add OTP requires validation Mar 27, 2024
@pdonias pdonias merged commit 61d167a into master Mar 27, 2024
1 check passed
@pdonias pdonias deleted the better-otp branch March 27, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julien-f @pdonias @MathieuRA