Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web, xo-server): HA setup in pool advanced tab #7503

Merged
merged 4 commits into from
Mar 28, 2024
Merged

feat(xo-web, xo-server): HA setup in pool advanced tab #7503

merged 4 commits into from
Mar 28, 2024

Conversation

b-Nollet
Copy link
Contributor

@b-Nollet b-Nollet commented Mar 25, 2024 •
edited

Description

HA setup in pool advanced tab
Fixes #4731

image

Trying to use the toggle :
image
image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@b-Nollet b-Nollet force-pushed the ha-setup branch 3 times, most recently from 4c86562 to 496d213 Compare March 27, 2024 10:50
@b-Nollet b-Nollet marked this pull request as ready for review March 27, 2024 10:54
pdonias
pdonias requested changes Mar 27, 2024
View reviewed changes
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
@b-Nollet b-Nollet requested a review from pdonias March 27, 2024 16:16
fbeauchamp
fbeauchamp requested changes Mar 28, 2024
View reviewed changes
packages/xo-server/src/api/pool.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/api/pool.mjs Outdated Show resolved Hide resolved
pdonias
pdonias requested changes Mar 28, 2024
View reviewed changes
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-server/src/api/pool.mjs Show resolved Hide resolved
@b-Nollet b-Nollet requested a review from pdonias March 28, 2024 10:48
pdonias
pdonias approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xo-web ok, not tested. Once xo-server is ok too, make sure to test end-to-end to make sure the latest changes refs → IDs didn't break anything :)

@fbeauchamp fbeauchamp merged commit a9692cd into master Mar 28, 2024
1 check passed
@fbeauchamp fbeauchamp deleted the ha-setup branch March 28, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

@fbeauchamp fbeauchamp fbeauchamp approved these changes

@pdonias pdonias pdonias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow set up of Heartbeat SR
4 participants
@b-Nollet @fbeauchamp @julien-f @pdonias