Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/new VM): warn if pool is not setup for secure boot #7562

Merged
merged 11 commits into from
Apr 30, 2024
Merged

feat(xo-web/new VM): warn if pool is not setup for secure boot #7562

merged 11 commits into from
Apr 30, 2024

Conversation

Pizzosaure
Copy link
Contributor

@Pizzosaure Pizzosaure commented Apr 16, 2024 •
edited

Description

Fixes #7500
At VM creation, warn if secure boot is on but pool is not setup to.
image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@Pizzosaure Pizzosaure marked this pull request as ready for review April 16, 2024 11:09
@Pizzosaure Pizzosaure requested a review from pdonias April 16, 2024 11:09
pdonias
pdonias requested changes Apr 17, 2024
View reviewed changes
packages/xo-server/src/xapi-object-to-xo.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xapi-object-to-xo.mjs Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Outdated Show resolved Hide resolved
@Pizzosaure Pizzosaure requested review from pdonias and MathieuRA and removed request for pdonias April 17, 2024 09:12
@MathieuRA MathieuRA changed the title feat(xo-web/VM): At VM creation, warn if pool is not setup for secure boot feat(xo-web/VM): at VM creation, warn if pool is not setup for secure boot Apr 19, 2024
MathieuRA
MathieuRA requested changes Apr 19, 2024
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/new-vm/index.js Outdated Show resolved Hide resolved
@Pizzosaure Pizzosaure requested a review from pdonias April 30, 2024 07:49
MathieuRA
MathieuRA previously requested changes Apr 30, 2024
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@pdonias pdonias changed the title feat(xo-web/VM): at VM creation, warn if pool is not setup for secure boot feat(xo-web/new VM): warn if pool is not setup for secure boot Apr 30, 2024
@pdonias pdonias merged commit 63ebfce into master Apr 30, 2024
1 check passed
@pdonias pdonias deleted the warningWhenSecureBootNotSetup branch April 30, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

@MathieuRA MathieuRA MathieuRA left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn before UEFI VM creation if Secure Boot is on but the pool is not setup for SB
3 participants
@Pizzosaure @pdonias @MathieuRA