Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the translation of Japanese #7582

Closed
wants to merge 2 commits into from
Closed

Conversation

kohju
Copy link

@kohju kohju commented Apr 23, 2024

Description

Just a Japanese translation for Japanese users.
These days, some part of VMware users are looking for an alternative virtual environment instead of VMware.
It seems like an opportunity to raise XenOrchestra awareness for Japanese Users.

This translation is not perfect now, but I will continue to translate if I have time.

Checklist

  • Commit
    • Add the pulldown option "ja", so users can select Japanese in index.js.
    • Add the ja.js in intl.

@olivierlambert
Copy link
Member

Hello @kohju and thank you very much for your contribution. I'll ping the team so we'll be sure to review it before our next release 👍

@pdonias pdonias self-requested a review April 23, 2024 09:53
@pdonias
Copy link
Member

pdonias commented Apr 24, 2024

@kohju Thanks for the PR! We just need to update the changelog and it's ready to merge :) I would do it but I don't have permissions to push to your branch. In the file CHANGELOG.unreleased.md, could you add:

  • This line at the end of the Enhancements section:
- [i18n] Japanese translation (PR [#7582](https://github.com/vatesfr/xen-orchestra/pull/7582))
  • And this at the end of the package list at the bottom of the file:
- xo-web minor

Thanks!

MathieuRA pushed a commit that referenced this pull request Apr 26, 2024
@kohju
Copy link
Author

kohju commented May 11, 2024

@pdonias
Thank you for your edition instead of me.

I have a question.
I want to update Japanese translation script, what should I do?

  1. create new branch or merge edge master to this branch?
  2. pull request same way and add package list 'xo-web minor' and other to do?

Regards,
TAKI.

@pdonias
Copy link
Member

pdonias commented May 13, 2024

  1. You can create a new branch from the up-to-date master branch, it will be easier to follow the git history
  2. Ideally, you would add a changelog entry in "Enhancements" like - [i18n] Update Japanese translation (PR [#xxxx](https://github.com/vatesfr/xen-orchestra/pull/xxxx)) and then - xo-web minor in "Packages to release". However, if you don't want to worry about the changelog, you can simply allow us to push to your branch and we'll do that for you right before merging your PR! :)

Thanks again for you contribution!

And actually, I forgot to close this PR in favor of #7605

@pdonias pdonias closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants