Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/pool): only show pool SRs in default SR selector #7626

Merged
merged 2 commits into from
May 6, 2024
Merged

fix(xo-web/pool): only show pool SRs in default SR selector #7626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a46b9a
fix(xo-web/pool): only show pool SRs in default SR selector
pdonias May 2, 2024
6839c40
Changelog
pdonias May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
> Users must be able to say: “I had this issue, happy to know it's fixed”

- [Pool] Fix `Headers Timeout Error` when installing patches on XCP-ng
- [Pool/Advanced] Only show current pool's SRs in default SR selector (PR [#7626](https://github.com/vatesfr/xen-orchestra/pull/7626))

### Packages to release

Expand All @@ -30,5 +31,6 @@
<!--packages-start-->

- xo-server patch
- xo-web patch

<!--packages-end-->
4 changes: 2 additions & 2 deletions packages/xo-web/src/xo-app/pool/tab-advanced.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,10 @@ class PoolMaster extends Component {
}))
class SelectDefaultSr extends Component {
render() {
const { defaultSr } = this.props
const { defaultSr, pool } = this.props

return (
<XoSelect onChange={setDefaultSr} value={defaultSr} xoType='SR'>
<XoSelect onChange={setDefaultSr} value={defaultSr} xoType='SR' predicate={sr => sr.$pool === pool.id}>
{defaultSr !== undefined ? <Sr id={defaultSr.id} /> : _('noValue')}
</XoSelect>
)
Expand Down
Loading