Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

fea(xo-web-6) Specification #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

GHEMID-Mohamed
Copy link
Contributor

No description provided.

│ ├── VBD
│ └── VM_snapshot
├── VM_template
├── VM_controller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I delete it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, but as we said tomorrow in the meeting, it's not at the correct position.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a VM_controller object. As I see, it's linked to a pool and a VBD.
Where do you think it's the right position ?

Screenshot from 2019-11-19 16-16-10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also linked to the host ($container).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now that a $container is a $host.. So I should move all VM types underneath host, what do you think ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A $container is not always a host, it can be a pool if the VM is not on a specific host (not running and disks on shared SR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so putting it under a host is a bad idea, I think that we should keep it underneath a pool,

README.md Outdated
│ ├── VDI_snapshot
│ └── VDI_unmanaged
└── Network
├── VIF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underneath VM.

README.md Outdated
│ └── VDI_unmanaged
└── Network
├── VIF
└── PIF
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underneath host.

README.md Outdated
├── VM
│ ├── VBD
│ └── VM_snapshot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this name come from?

Please choose either XAPI or XO types and use them exactly (case and all).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've chosen to work with XO Types, thereby VM_snapshot is an existing type, and it's linked either to a pool or a VM.

To keep homogeneity, I'll move it underneath pool

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've chosen to work with XO Types, thereby VM_snapshot is an existing type, and it's linked either to a pool or a VM.

Ok, then why is Host capitalize?

To keep homogeneity, I'll move underneath pool

IMHO, it makes sense to have them under the related VM if there is one, otherwise it should be below the host or pool like a normal VM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants