Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve console architecture using multiple levels of PicoCLI #155

Open
lolski opened this issue May 18, 2021 · 2 comments
Open

Improve console architecture using multiple levels of PicoCLI #155

lolski opened this issue May 18, 2021 · 2 comments
Labels
priority: medium type: refactor

Comments

@lolski
Copy link
Member

lolski commented May 18, 2021 •
edited
Loading

Make sure the style and terminology is consistent with TypeDB
TypeDB is the reference implementation which we should adhere to.

Make the logic that parses the command terser and stricter, and with minimal boilerplate
Please take a look at this Demonstrational PR on how much effort it takes to add relatively simple functionality. The parser is not strict and error prone, and it requires a lot of boilerplate. There are some nuances in how we should best approach the refactor, which we should discuss verbally.
@lolski lolski mentioned this issue May 26, 2021
Closed
@flyingsilverfin flyingsilverfin changed the title Refactor the CLI option aspects Improve console architecture using multiple levels of PicoCLI Jun 2, 2021
@flyingsilverfin
Copy link
Member

If we still need a way to escape an inner CLI without exiting completely, we can replace the boolean that is passed around for success with an Enum which will be more meaningful and easy to read

lolski pushed a commit to lolski/typedb-console that referenced this issue Jun 9, 2021
@vmax
Reenable remote build caching (vaticle#155)
ce659c1 
## What is the goal of this PR?

Speed up builds by utilizing remote caching provided by BuildBuddy.

## What are the changes implemented in this PR?

Reenable build caching (without remote execution) on all CI jobs
@haikalpribadi
Copy link
Member

This issue may be overridden by this one: #162

@lriuui0x0 lriuui0x0 removed their assignment Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium type: refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lolski @haikalpribadi @flyingsilverfin @lriuui0x0