Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console should not exit when reattempting to open a transaction to a database that does not exist #98

Closed
lolski opened this issue Jan 11, 2021 · 1 comment · Fixed by #104
Closed

Console should not exit when reattempting to open a transaction to a database that does not exist #98

lolski opened this issue Jan 11, 2021 · 1 comment · Fixed by #104
Assignees
@lriuui0x0
Labels
priority: medium status: solved type: bug

Comments

@lolski
Copy link
Member

lolski commented Jan 11, 2021

Trying to open a transaction to a database that does not exist is a recoverable error. Therefore, we should catch and recover from it instead of exiting.
@lriuui0x0
Copy link
Contributor

We should make sure the exception class that's thrown is correct.

@lriuui0x0 lriuui0x0 assigned lriuui0x0 and unassigned vmax Jan 13, 2021
@lriuui0x0 lriuui0x0 mentioned this issue Jan 13, 2021
Merged
lolski pushed a commit that referenced this issue Jan 13, 2021
@lriuui0x0
Fix console exitting when trying to open transaction to a database th…
8252bba 
…at doesn't exist (#104)

## What is the goal of this PR?

We have fixed an issue that caused console to exit when trying to open transaction to a database that doesn't exist.

## What are the changes implemented in this PR?

- Bump client-java to the version which no longer throws the incorrect exception, causing console to exit improperly
- Fix #98
lolski pushed a commit to lolski/typedb-console that referenced this issue Jun 9, 2021
Overhaul query options (typedb#98)
70621f2 
## What is the goal of this PR?
We introduce modified `infer`, and new `batch_size`, and `explain` options for queries:

The default (undefined setting of the above options) value means that the server will automatically choose the default value for `infer`, `explain`, and `batch_size`. For reference, the server will default to `infer = true`, `explain = true`, and `batch_size = 50`.

** use `explain:true` if you want to retrieve explanations from your query ** This was introduced to ensure correct Explanations, without consuming too much Transaction memory when not required.

## What are the changes implemented in this PR?
* Introduce `explain` query option
* Include `batchSize` query option into the query options, instead of iteration options
* Throw exceptions if the types of parameters are passed in are incorrect.
* Tests for `explain` and `infer` flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lriuui0x0 lriuui0x0

Labels
priority: medium status: solved type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix console exitting when trying to open transaction to a database that doesn't exist
4 participants
@lolski @vmax @haikalpribadi @lriuui0x0