Fix APT package deployment #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolski
reviewed
Aug 4, 2021
.grabl/automation.yml
Outdated
| @@ -119,6 +125,12 @@ release: | |||
| cat VERSION | |||
| export DEPLOY_APT_USERNAME=$REPO_VATICLE_USERNAME | |||
| export DEPLOY_APT_PASSWORD=$REPO_VATICLE_PASSWORD | |||
| # Downgrading Python is needed to work around bazelbuild/rules_pkg#397 | |||
There was a problem hiding this comment.
The comment should be like this I think:
# Do not upgrade Python until bazelbuild/rules_pkg#397 is fixed
The current comment will be confusing when read without context
lolski
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Make APT package that we deploy installable again
What are the changes implemented in this PR?
Use Python 3.7 version to run
deploy-apt-*jobs to avoid bazelbuild/rules_pkg#397