Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store UUIDs as bytes, not strings #134

Closed
alexjpwalker opened this issue Apr 7, 2021 · 0 comments · Fixed by #135
Closed

Store UUIDs as bytes, not strings #134

alexjpwalker opened this issue Apr 7, 2021 · 0 comments · Fixed by #135
Assignees
@alexjpwalker
Labels
status: solved type: feature

Comments

@alexjpwalker
Copy link
Member

Problem to Solve

UUID representation as string is inefficient.

Proposed Solution

Store Session IDs and Request IDs (and any other UUIDs) as bytes, not strings.
@alexjpwalker alexjpwalker self-assigned this Apr 7, 2021
@alexjpwalker alexjpwalker mentioned this issue Apr 7, 2021
Merged
haikalpribadi pushed a commit that referenced this issue Apr 8, 2021
Store request IDs as bytes; add 'inferred' to Thing (#135)
8f5d976 
## What is the goal of this PR?

Previously the field `req_id` of a transaction request was stored as a string, which is an inefficient representation of a UUID. We've changed it to bytes.

Also, we deleted `IsInferred` and added the `inferred` flag to `Thing`, allowing clients to check if a Thing is inferred without an additional network roundtrip.

## What are the changes implemented in this PR?

Store request IDs as bytes, not strings (fixes #134 )
Add 'inferred' to Thing (fixes vaticle/typedb-driver#314 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexjpwalker alexjpwalker

Labels
status: solved type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store request IDs as bytes; add 'inferred' to Thing alexjpwalker/typedb-protocol
2 participants
@alexjpwalker @grabl