-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sentry error reporting for all fatal errors #815
Add sentry error reporting for all fatal errors #815
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
Studio.kt
Outdated
@@ -305,6 +315,31 @@ object Studio { | |||
UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName()) // Set UI style for Windows | |||
} | |||
|
|||
private fun configureDiagnostics() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a very rudimentary hard coding
package(default_visibility = ["//visibility:public"]) | ||
|
||
genrule( | ||
name = "version-src", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Templated version file, just like in Core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
9261465
to
7147be2
Compare
Usage and product changes
We add anonymous Sentry error reporting for all fatal errors in TypeDB Studio. The Studio version and a hash of the mac address (if available) are reported along with the error.
Users can opt-out of the diagnostics reporting with a new checkbox in the
Preferences -> System
checkbox. Note that a Studio restart is required for the toggle to take effect.Implementation