Skip to content

Commit

Permalink
Rename Definition -> DefinitionKey, StructValueType -> StructDefinition
Browse files Browse the repository at this point in the history
  • Loading branch information
flyingsilverfin committed May 29, 2024
1 parent 212c82e commit 92985c1
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ use crate::{AsBytes, EncodingKeyspace, Keyable, Prefixed};
use crate::layout::prefix::{Prefix, PrefixID};

#[derive(Clone, Debug, PartialEq, Eq, Hash, Ord, PartialOrd)]
pub struct Definition<'a> {
pub struct DefinitionKey<'a> {
bytes: Bytes<'a, { BUFFER_KEY_INLINE }>,
}

impl<'a> Definition<'a> {
impl<'a> DefinitionKey<'a> {
pub(crate) const KEYSPACE: EncodingKeyspace = EncodingKeyspace::Schema;
pub const FIXED_WIDTH_ENCODING: bool = true;

Expand All @@ -39,7 +39,7 @@ impl<'a> Definition<'a> {
}
}

impl<'a> AsBytes<'a, BUFFER_KEY_INLINE> for Definition<'a> {
impl<'a> AsBytes<'a, BUFFER_KEY_INLINE> for DefinitionKey<'a> {
fn bytes(&'a self) -> ByteReference<'a> {
self.bytes.as_reference()
}
Expand All @@ -49,13 +49,13 @@ impl<'a> AsBytes<'a, BUFFER_KEY_INLINE> for Definition<'a> {
}
}

impl<'a> Keyable<'a, BUFFER_KEY_INLINE> for Definition<'a> {
impl<'a> Keyable<'a, BUFFER_KEY_INLINE> for DefinitionKey<'a> {
fn keyspace(&self) -> EncodingKeyspace {
Self::KEYSPACE
}
}

impl<'a> Prefixed<'a, BUFFER_KEY_INLINE> for Definition<'a> {}
impl<'a> Prefixed<'a, BUFFER_KEY_INLINE> for DefinitionKey<'a> {}

#[derive(Debug, Copy, Clone, PartialEq, Eq)]
pub struct DefinitionID {
Expand Down
2 changes: 1 addition & 1 deletion encoding/graph/definition/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
*/

pub mod r#struct;
pub(crate) mod definition;
pub(crate) mod definition_key;
6 changes: 3 additions & 3 deletions encoding/graph/definition/struct.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ use crate::value::value_type::ValueType;

/// Restrictions: maximum number fields is StructFieldNumber::MAX
#[derive(Serialize, Deserialize, Debug, Clone, Eq, PartialEq)]
pub struct StructValueType {
pub struct StructDefinition {
name: String,
fields: Vec<StructField>,
fields: Vec<StructDefinitionField>,
field_names: HashMap<String, StructFieldNumber>,
}

#[derive(Serialize, Deserialize, Debug, Clone, Eq, PartialEq)]
pub struct StructField {
pub struct StructDefinitionField {
optional: bool,
value_type: ValueType,
index: StructFieldNumber,
Expand Down
4 changes: 2 additions & 2 deletions encoding/value/struct_value.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@


use std::collections::HashMap;
use crate::graph::definition::definition::Definition;
use crate::graph::definition::definition_key::DefinitionKey;

use crate::graph::definition::r#struct::StructFieldNumber;
use crate::value::ValueEncodable;

#[derive(Debug)]
pub struct StructValue {
definition: Definition<'static>,
definition: DefinitionKey<'static>,

// a map allows empty fields to not be recorded at all
fields: HashMap<StructFieldNumber, Box<dyn ValueEncodable>>
Expand Down

0 comments on commit 92985c1

Please sign in to comment.