Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SonarCloud reporting to our CI #4187

Closed
grabl opened this issue Sep 22, 2018 · 4 comments · Fixed by #5319
Closed

Add SonarCloud reporting to our CI #4187

grabl opened this issue Sep 22, 2018 · 4 comments · Fixed by #5319
Assignees
@lolski
Labels
domain: build status: solved type: feature

Comments

@grabl
Copy link
Contributor

grabl commented Sep 22, 2018

This issue was originally posted by @haikalpribadi on 2018-08-09 00:04.

Add Sonar source code analysis report to our CI. You can find the maven command below. I imagine we could just add it to the very end of the build job, before parallelisation happens - just an idea.

 mvn sonar:sonar  -Dsonar.organization=graknlabs  -Dsonar.host.url=https://sonarcloud.io  -Dsonar.login=0e7fa3e66933e150011ec823c840c60529d05063
@grabl
Copy link
Contributor Author

grabl commented Sep 22, 2018

This comment was originally posted by @haikalpribadi on 2018-08-09 00:07:19+02:00.

I'm not sure which requirement to attach this to, @lolski. Perhaps we should align the requirements on CD, which we haven't done lately.

@grabl
Copy link
Contributor Author

grabl commented Sep 22, 2018

This comment was originally posted by @haikalpribadi on 2018-08-11 22:20:49+02:00.

The token above is set to this new graknlabs account on SonarCloud, @lolski. (It's new, not the old one Filipe created). I've assigned you as admin, so you should be able to make changes. Basically, I'm trying to achieve what is shown in this page but can't seem to find the documentation on how to do it. There is something similar here, but it's for SonarCube, not SonarCloud (I believe SonarCloud is SonarCube run as a service).

@grabl grabl mentioned this issue Sep 22, 2018
Open
@lolski lolski added this to the v1.5 milestone Sep 24, 2018
@lolski lolski added the v1.5 label Sep 24, 2018
@lolski lolski removed this from the v1.5 milestone Sep 24, 2018
@lolski lolski removed the v1.5 label Sep 24, 2018
@haikalpribadi haikalpribadi added this to the v1.6 milestone Jan 6, 2019
@grabl grabl added the v1.6 label Jan 6, 2019
@lolski lolski removed this from the v1.6 milestone Apr 1, 2019
@vmax
Copy link
Contributor

vmax commented Apr 22, 2019

@haikalpribadi @lolski do you think we still need it?

@haikalpribadi
Copy link
Member

yes, we still need it, @vmax. But neither @lolski or I have had the time to look into it.

@lolski lolski mentioned this issue Jul 8, 2019
Merged
haikalpribadi pushed a commit that referenced this issue Jul 8, 2019
@lolski @haikalpribadi
Implements code quality analysis powered by sonarcloud.io (#5319)
cf0a893 
## What is the goal of this PR?

We have integrated sonarcloud.io with the intention of increasing the visibility of source code health (fixes #4187).

The code analysis step is ran in the `build` CI job and the result can be viewed at https://sonarcloud.io/dashboard?id=graknlabs-grakn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolski lolski

Labels
domain: build status: solved type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implements code quality analysis powered by sonarcloud.io lolski/typedb
4 participants
@lolski @vmax @haikalpribadi @grabl