Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Grakn dependency in client-java, python, nodejs, workbase, docs, and examples #4890

Closed
lolski opened this issue Feb 10, 2019 · 0 comments

Comments

@lolski
Copy link
Member

lolski commented Feb 10, 2019

This ticket should be done after https://github.com/graknlabs/grakn/issues/4894

  • The syncing should be done in a job in the workflow named ci
  • The job should only be ran when there is a new commit in master.
  • The job updates the Grakn dependencies of client-java located in the development branch
  • We should be able to generalise the script used for docs so we can reuse it, instead of creating a new one which would end up looking similar

We've already done something similar for docs, therefore the job should be somewhat alike:

jobs:
  dependency-update:
    machine: true
    steps:
      - checkout
      - run:
          name: Update Grakn dependency in client-java, python, nodejs, workbase, docs, and examples
          command: |
            mkdir docs
            cd docs
            bazel run @graknlabs_grabl//sync:dependency-update -- --dependency grakn:master --user client-java:development client-python:development client-nodejs:development workbase:development 
 docs:development examples:development

...

workflows:
  ci:
    jobs:

      ...

      # sync client-java/development to the latest grakn version
      - dependency-update:
          filters:
            branches:
              only: master
          requires:
              ...
@lolski lolski self-assigned this Feb 10, 2019
@haikalpribadi haikalpribadi changed the title Sync Grakn dependencies in client-java Update Grakn dependencies in client-java Feb 10, 2019
@haikalpribadi haikalpribadi changed the title Update Grakn dependencies in client-java Update Grakn dependency in client-java Feb 10, 2019
@lolski lolski changed the title Update Grakn dependency in client-java Update Grakn dependency in client-java, python, nodejs, workbase, docs, and examples Feb 10, 2019
@vmax vmax self-assigned this Feb 26, 2019
vmax added a commit that referenced this issue Mar 1, 2019
)

## What is the goal of this PR?

Completes part of #4890
`workbase` to be done after vaticle/typedb-studio#69 is merged
`examples` are not bazelized yet

## What are the changes implemented in this PR?

Uses new dependency updater script to bump `@graknlabs_grakn_core` version in `docs` and `client-*`
@haikalpribadi haikalpribadi added this to the v1.5 milestone Mar 1, 2019
haikalpribadi pushed a commit that referenced this issue Mar 2, 2019
## What is the goal of this PR?

Adapt dependency update to newest branching model for clients
Closed #4890

## What are the changes implemented in this PR?

- Replaces `development` branch with `master` for clients as per latest decision on branching model
- Removes `.circleci/grakn-docs-update.py` as it's no longer used
- Adds `workbase:master` for automatic updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants