Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tagged workflow and references in circleci config #2954

Merged
merged 1 commit into from Aug 15, 2018

Conversation

marco-scoppetta
Copy link
Contributor

@marco-scoppetta marco-scoppetta commented Aug 14, 2018

Why is this PR needed?

CircleCI config is becoming really big and still does not have workflow for continuous delivery/deployment

What does the PR do?

  • Tidies up the file using references
  • Adds a new build-and-deploy workflow to execute deployment jobs (still to be tested and completed) - this workflow ignores all the PR coming from any branch and it will only be triggered on commits with a git tag attached

Does it break backwards compatibility?

no

List of future improvements not on this PR

no

Copy link
Member

@lolski lolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marco-scoppetta marco-scoppetta merged commit 659f09e into vaticle:master Aug 15, 2018
@marco-scoppetta marco-scoppetta deleted the circle branch August 21, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants