Refactor handling of value predicates #5226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-scoppetta
approved these changes
May 31, 2019
kasper-piskorski
added a commit
that referenced
this pull request
Jul 5, 2019
## What is the goal of this PR? Remove the use of `neqPositive` which is obsolete after the changes introduced in #5226. The use of `neqPositive` in the current context leads to potential issues - if a query contains `!== ` predicates with a value, they might be omitted if other variable predicates are present. This PR fixes that. ## What are the changes implemented in this PR? - remove the `neqPositive` member of `Atomic` and its uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
To fix issues and simplify processing of value predicates within queries with inference.
Fixed problems:
What are the changes implemented in this PR?
VariableValuePredicateclass being a generalisation of the previousNeqValuePredicate.VariableComparisonStatewhich now handles all predicates (id and value) with variables