Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge typedb-common repository into typeql #313

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Merge typedb-common repository into typeql #313

merged 8 commits into from
Jan 25, 2024

Conversation

dmitrii-ubskii
Copy link
Member

@dmitrii-ubskii dmitrii-ubskii commented Jan 25, 2024 •
edited

What is the goal of this PR?

As part of the effort to reduce the number of vaticle organization repositories, we merge typedb-common into the typeql repo as a subpackage.

@vaticle-bot
Copy link
Member

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@dmitrii-ubskii dmitrii-ubskii added type: build priority: blocker dependencies Pull requests that update a dependency file labels Jan 25, 2024
@dmitrii-ubskii dmitrii-ubskii marked this pull request as ready for review January 25, 2024 14:09
flyingsilverfin
flyingsilverfin reviewed Jan 25, 2024
View reviewed changes
common/java/BUILD Outdated Show resolved Hide resolved
flyingsilverfin
flyingsilverfin reviewed Jan 25, 2024
View reviewed changes
common/java/BUILD Outdated Show resolved Hide resolved
flyingsilverfin
flyingsilverfin reviewed Jan 25, 2024
View reviewed changes
common/java/BUILD Outdated Show resolved Hide resolved
flyingsilverfin
flyingsilverfin requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@flyingsilverfin flyingsilverfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please double make sure you notify the team so they know that these files have a new home

@flyingsilverfin flyingsilverfin merged commit 230842f into vaticle:development Jan 25, 2024
4 of 5 checks passed
@dmitrii-ubskii dmitrii-ubskii mentioned this pull request Jan 29, 2024
Merged
flyingsilverfin pushed a commit to vaticle/typedb that referenced this pull request Jan 29, 2024
@dmitrii-ubskii
Transition from standalone typedb-common to typeql/common (#6976)
c5831b4 
## Usage and product changes

We update Bazel dependencies and target paths following the merging of
typedb-common into [vaticle/typeql](https://github.com/vaticle/typeql/)
(see vaticle/typeql#313).
This was referenced Jan 29, 2024
Merged
Merged
flyingsilverfin pushed a commit to vaticle/typedb-driver that referenced this pull request Jan 29, 2024
@dmitrii-ubskii
Transition from standalone typedb-common to typeql/common (#582)
20b9f1d 
## Usage and product changes

We update Bazel dependencies and target paths following the merging of
typedb-common into [vaticle/typeql](https://github.com/vaticle/typeql/)
(see vaticle/typeql#313).
dmitrii-ubskii added a commit to vaticle/typedb-console that referenced this pull request Jan 30, 2024
@dmitrii-ubskii
Use typedb-common from typeql/common, only deploy to CloudSmith (#231)
0131206 
## Usage and product changes

We update Bazel dependencies and target paths following the merging of
typedb-common into [vaticle/typeql](https://github.com/vaticle/typeql/)
(see vaticle/typeql#313).

We also no longer upload build artifacts to the github releases page.
Instead, the artifacts are available from our public cloudsmith
repository, linked in the release notes.

## Implementation

- update ghr to 0.16.2, as 0.12.1 does not support github releases
without artifacts
farost pushed a commit to farost/typedb-driver that referenced this pull request Mar 21, 2024
@dmitrii-ubskii @farost
Transition from standalone typedb-common to typeql/common (vaticle#582)
cbb2276 
## Usage and product changes

We update Bazel dependencies and target paths following the merging of
typedb-common into [vaticle/typeql](https://github.com/vaticle/typeql/)
(see vaticle/typeql#313).
farost pushed a commit to farost/typedb-driver that referenced this pull request Mar 21, 2024
@dmitrii-ubskii @farost
Transition from standalone typedb-common to typeql/common (vaticle#582)
0095577 
## Usage and product changes

We update Bazel dependencies and target paths following the merging of
typedb-common into [vaticle/typeql](https://github.com/vaticle/typeql/)
(see vaticle/typeql#313).
farost pushed a commit to farost/typedb-driver that referenced this pull request Mar 21, 2024
@dmitrii-ubskii @farost
Transition from standalone typedb-common to typeql/common (vaticle#582)
4dce322 
## Usage and product changes

We update Bazel dependencies and target paths following the merging of
typedb-common into [vaticle/typeql](https://github.com/vaticle/typeql/)
(see vaticle/typeql#313).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyingsilverfin flyingsilverfin flyingsilverfin approved these changes

@haikalpribadi haikalpribadi Awaiting requested review from haikalpribadi haikalpribadi is a code owner

Assignees

@haikalpribadi haikalpribadi

@flyingsilverfin flyingsilverfin

Labels
dependencies Pull requests that update a dependency file priority: blocker type: build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmitrii-ubskii @vaticle-bot @flyingsilverfin @haikalpribadi