Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI pylint #1439

Closed
BoPeng opened this issue May 24, 2021 · 7 comments
Closed

Fix CI pylint #1439

BoPeng opened this issue May 24, 2021 · 7 comments

Comments

@BoPeng
Copy link
Contributor

BoPeng commented May 24, 2021

pylint fails due to some weird error, and we should fix it.

@he1l0world
Copy link
Contributor

I guess I found a similar issue mentioned in Here, the command "s -R|grep .py$|xargs" will only list all files not the path, so that's why it will give a bunch of error about missing module name.

Can I make a PR with the new command?

@BoPeng
Copy link
Contributor Author

BoPeng commented Jun 27, 2021

I have alredy started working on this on the test branch, which changed the command to pylint src/sos. There are still a bunch of pylint error though.

I think you can create a PR against the test branch.

@he1l0world
Copy link
Contributor

Sure, sounds good.

@BoPeng
Copy link
Contributor Author

BoPeng commented Jun 27, 2021

Because pylint gives many many warnings, I added a file .github/linters/.python-lint to disable many of the warnings that I deemed non-essential. This pylint configuration file is used by super-linter, a linter that I use for other projects, but I am not sure if pylint.yml uses this file.

I suspect that .pylint.yml uses something like .pylintrc on the project home directory.

@he1l0world
Copy link
Contributor

Ok, I can look it up and add the configuration file to the command.

@he1l0world
Copy link
Contributor

he1l0world commented Jun 28, 2021

I think you are right that the pylint uses .pylintrc file as the configuration file, I tested it on my side, and turns out that the pylint can also use the .python-lint as long as it specifies the config file name in the command. I can go ahead and create a PR for that.

@BoPeng
Copy link
Contributor Author

BoPeng commented May 2, 2022

This is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants