Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved screenshots #189

Merged
merged 2 commits into from Aug 5, 2021
Merged

Improved screenshots #189

merged 2 commits into from Aug 5, 2021

Conversation

therealsujitk
Copy link
Collaborator

image

image

@therealsujitk therealsujitk changed the title Improve screenshots Improved screenshots Jul 31, 2021
@vatz88
Copy link
Owner

vatz88 commented Aug 5, 2021

Thanks @therealsujitk This looks great! Sorry about delayed response, I'm on a vacation/ traveling. Will review your other PRs too

@vatz88 vatz88 merged commit 6d73942 into vatz88:master Aug 5, 2021
@therealsujitk
Copy link
Collaborator Author

@vatz88 no problem! Take your time, I think our FFCS registrations are over for this semester and these PRs are just improvements and bug fixes. Let me know if you need any changes to be made.

@vatz88
Copy link
Owner

vatz88 commented Aug 5, 2021

@therealsujitk I tried on mobile and it seems screenshot is not working the 2nd time you try it. Can you please check

@therealsujitk
Copy link
Collaborator Author

@vatz88 I just checked, I was able to download both images multiple times. Can you give me steps to reproduce?

@vatz88
Copy link
Owner

vatz88 commented Aug 5, 2021

On my phone it seems like if the table name is same it's not downloading again

@therealsujitk
Copy link
Collaborator Author

therealsujitk commented Aug 5, 2021

On my phone it seems like if the table name is same it's not downloading again

🤔 it could be because the OS or browser is preventing multiple downloads thinking it already exisits, you use Safari on iOS? Android allows multiple downloads automatically renaming them. Is it the same if you make some change (like adding a course) and then download it with the same table name? Maybe if it compares binaries it'll understand it's not the same file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants