Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"?return_to=/projects" seems to be ignoring sonar.web.context #55

Closed
tonihoang opened this issue Oct 5, 2021 · 2 comments
Closed

"?return_to=/projects" seems to be ignoring sonar.web.context #55

tonihoang opened this issue Oct 5, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@tonihoang
Copy link
Contributor

tonihoang commented Oct 5, 2021

When I am redirected form my OIDC provider I get returned to {mydomain}/projects, which is not found.

Shouldn't it take the sonar.web.context into account?

I have not found anything in code except:

private static final String OIDC_URL = "/sessions/init/" + OidcIdentityProvider.KEY + "?return_to=/projects";

but this is hardcoding "/projects" I assume it should contain the config.getBaseUrl()?

-->

private static final String OIDC_URL = "/sessions/init/" + OidcIdentityProvider.KEY + "?return_to=" + config.getBaseUrl() + "/projects";

to be correct?

As I am unable to test it right now I did not create a PR yet.

@tjuerge tjuerge added the bug label Oct 6, 2021
@tjuerge tjuerge added this to the 2.1.1 milestone Oct 6, 2021
@tjuerge tjuerge self-assigned this Oct 6, 2021
@tjuerge
Copy link
Contributor

tjuerge commented Oct 6, 2021

Thanks for spotting that.

@tonihoang
Copy link
Contributor Author

tonihoang commented Oct 6, 2021

Created a PR #56

But did not go through everything so that would be a quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants