-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made structural pattern matching practicable... #1167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
danieldietrich
added a commit
that referenced
this pull request
Mar 4, 2016
Made structural pattern matching practicable...
Towards #1087 |
This was referenced Mar 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by reducing the amount of generated methods (per unapply method) from
11^n
to1
, wheren
is the number of unapplied fields of an object.Now, object trees of arbitrary(!) depth can be matched but the decomposition takes place in the first level of the object tree (the given object is level 0).
Before we could select arbitrary nodes of the object tree. That is not possible any more because it requires the patterns to return the actual arity using tuples - and therefore all possible return combinations had to be generated. This is simply not possible resp. practicable in a real-world application and soon exceeds the class file size. However, this is solved with this PR!!!