Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Microsoft Visual Studio compilation support #12

Closed
JanSimek opened this issue Feb 2, 2014 · 3 comments
Closed

build: Microsoft Visual Studio compilation support #12

JanSimek opened this issue Feb 2, 2014 · 3 comments

Comments

@JanSimek
Copy link
Contributor

JanSimek commented Feb 2, 2014

I fixed the Windows build with MSVC. Unfortunately, I am at a loss on how to make a proper pull request which contains only these two commits and not the whole fork:

JanSimek@5c54572
JanSimek@0ce6c72

I haven't done any playtesting yet, but it compiles fine on Windows 7 and OS X 10.9

@vayerx
Copy link
Owner

vayerx commented Feb 3, 2014

If there are one or two commits, I can cherry-pick them manually. But if you would like to make a pull request, you should create a new branch from the latest fetched commit in target branch of my repository and cherry-pick necessary commits to that branch. Then you'll be able to create pull request.

vayerx added a commit that referenced this issue Feb 4, 2014
build: globally disable warnings for secure functions on Windows
build: Windows compilation fixes
@vayerx
Copy link
Owner

vayerx commented Feb 4, 2014

I've merged those commits. Thanks for patches!
I made small changes in data-paths logic -- please could you check if it works for Windows.

@JanSimek
Copy link
Contributor Author

JanSimek commented Feb 4, 2014

It's a little bit inconvenient, because this way you have to specify these data path variables on the command line and you can't use cmake-gui, because those variables are not set. Most people use cmake-gui to configure CMake-based projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants