Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support for Astronomy #44

Closed
RSchwan opened this issue Jun 24, 2016 · 6 comments
Closed

Feature request: Support for Astronomy #44

RSchwan opened this issue Jun 24, 2016 · 6 comments
Assignees
Labels
Help Wanted Orphaned and discontinued issues that need your help Type: Feature New features and feature requests

Comments

@RSchwan
Copy link
Contributor

RSchwan commented Jun 24, 2016

For my new project I use astronomy. I'm not sure how hard it is to add support for it or if it is even possible.
Next week I have some time available and would like to implement it.
The only thing is that I don't really know where to start. But I hope with some guidance it should be possible.

@serkandurusoy
Copy link
Contributor

You can start from https://github.com/rclai/meteor-astronomy-simple-schema

On Fri, Jun 24, 2016 at 9:56 PM, RSchwan notifications@github.com wrote:

For my new project I use astronomy
https://github.com/jagi/meteor-astronomy. I'm not sure how hard it is
to add support for it or if it is even possible.
Next week I have some time available and would like to implement it.
The only thing is that I don't really know where to start. But I hope with
some guidance it should be possible.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#44, or mute the thread
https://github.com/notifications/unsubscribe/AEbz3HCpOXarCXSJ2KJTPgYYYLNfZBSaks5qPChlgaJpZM4I-CFy
.

@radekmie radekmie added the Type: Question Questions and other discussions label Jun 24, 2016
@radekmie
Copy link
Contributor

To be honest, I've never been using astronomy personally, so I don't really know, what could be hard or problematic to implement.

I would also start with meteor-astronomy-simple-schema (you may take some notes from there).

Then those surely will be your reference: astronomy/fields and astronomy/validators.

Also, current SimpleSchema implementation could be very handy.

Every question is welcome (:

@radekmie radekmie added the Type: Feature New features and feature requests label Jun 24, 2016
@radekmie radekmie self-assigned this Jun 27, 2016
@radekmie
Copy link
Contributor

Hey, @RSchwan. Any progress? Need some help?

@RSchwan
Copy link
Contributor Author

RSchwan commented Jun 30, 2016

It's harder than I thought. For first level fields I have something working (not 100% satisfied). But I have problems with nested fields and arrays.
Also I switched from Astronomy to SimpleSchema. So I'm not sure if I'm going to work on it anymore.

@radekmie
Copy link
Contributor

How about sharing your code? You can create a PR, we mark it with help wanted - maybe someone will continue your work?

@radekmie radekmie added Help Wanted Orphaned and discontinued issues that need your help and removed Type: Question Questions and other discussions labels Jul 23, 2016
@radekmie radekmie added this to Needs triage in Open Source (migrated) Sep 25, 2019
@radekmie radekmie moved this from Needs triage to On hold in Open Source (migrated) Sep 25, 2019
@radekmie
Copy link
Contributor

Over three years and one mid-way PR later, it's still not finished. I'm closing due to a lack of interest. Feel free to comment or continue the PR.

Open Source (migrated) automation moved this from On hold to Closed Sep 25, 2019
@radekmie radekmie removed this from Closed in Open Source (migrated) Oct 9, 2019
@Monteth Monteth added this to Closed in Open Source (migrated) Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Orphaned and discontinued issues that need your help Type: Feature New features and feature requests
Projects
Archived in project
Development

No branches or pull requests

3 participants