Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to propagate 'classes' prop for SelectField on uniforms-material #700

Closed
p1Machado opened this issue Mar 31, 2020 · 3 comments · Fixed by #791
Closed

Unable to propagate 'classes' prop for SelectField on uniforms-material #700

p1Machado opened this issue Mar 31, 2020 · 3 comments · Fixed by #791
Assignees
Labels
Type: Feature New features and feature requests
Milestone

Comments

@p1Machado
Copy link

I am trying to style the FormControl in a SelectField, but neither style or classes are being provided to the TextField component.

I believe that at least the classes prop should be explicitly provided to TextField: https://github.com/vazco/uniforms/blob/master/packages/uniforms-material/src/SelectField.tsx

@radekmie radekmie added this to Needs triage in Open Source (migrated) Apr 1, 2020
@radekmie radekmie self-assigned this Apr 1, 2020
@radekmie radekmie added the Type: Feature New features and feature requests label Apr 1, 2020
@radekmie radekmie moved this from Needs triage to To do in Open Source (migrated) Apr 1, 2020
@radekmie
Copy link
Contributor

radekmie commented Apr 1, 2020

Hi @p1Machado. I don't see the FormControl, therefore I guess you meant the one rendered by the wrapField helper, right? Yep, it'd be nice to have it configurable as well. I think adding a wrapProps, similar to most of the props for AntD version of wrapField would be good and enough.

We're mostly finished with v3 and I think this could be added there.

@radekmie radekmie added this to the v3 milestone Apr 1, 2020
@radekmie radekmie modified the milestones: v3.0, v3.x Jun 6, 2020
@radekmie radekmie assigned Monteth and unassigned radekmie Aug 19, 2020
@Monteth Monteth moved this from To do to In progress in Open Source (migrated) Aug 26, 2020
Open Source (migrated) automation moved this from In progress to Closed Sep 23, 2020
@p1Machado
Copy link
Author

Hi @p1Machado. I don't see the FormControl, therefore I guess you meant the one rendered by the wrapField helper, right? Yep, it'd be nice to have it configurable as well. I think adding a wrapProps, similar to most of the props for AntD version of wrapField would be good and enough.

We're mostly finished with v3 and I think this could be added there.

I've meant TextField. Actually material-ui renders a FormControl inside the TextField component. This component used here is the one I was refering as missing a possibility of passing a classes prop.

Sorry for taking so long to reply.

@p1Machado
Copy link
Author

The solution made on #791 is what I was expecting! 👍

@radekmie radekmie modified the milestones: v3.x, v3.0 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants