-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typings of getNativeFormProps
#1044
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kestarumper
requested review from
radekmie,
Monteth,
wadamek65 and
piotrpospiech
October 6, 2021 17:04
kestarumper
changed the title
Improve typings of getNativeProps
Improve typings of Oct 6, 2021
getNativeProps
kestarumper
changed the title
Improve typings of
Improve typings of Oct 6, 2021
getNativeProps
getNativeFormProps
piotrpospiech
previously approved these changes
Oct 6, 2021
wadamek65
previously approved these changes
Oct 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
==========================================
- Coverage 98.98% 98.59% -0.39%
==========================================
Files 202 202
Lines 3156 3214 +58
Branches 798 829 +31
==========================================
+ Hits 3124 3169 +45
- Partials 32 45 +13
Continue to review full report at Codecov.
|
radekmie
suggested changes
Oct 8, 2021
kestarumper
dismissed stale reviews from wadamek65 and piotrpospiech
via
October 17, 2021 11:18
749f92a
radekmie
approved these changes
Oct 20, 2021
Monteth
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1037 by improving
.getNativeFormProps
by guaranteeingkey
andonChange
props and replacingany
withunknown
.