Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typings of getNativeFormProps #1044

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Conversation

kestarumper
Copy link
Member

@kestarumper kestarumper commented Oct 6, 2021

This PR closes #1037 by improving .getNativeFormProps by guaranteeing key and onChange props and replacing any with unknown.

@kestarumper kestarumper changed the title Improve typings of getNativeProps Improve typings of getNativeProps Oct 6, 2021
@kestarumper kestarumper changed the title Improve typings of getNativeProps Improve typings of getNativeFormProps Oct 6, 2021
piotrpospiech
piotrpospiech previously approved these changes Oct 6, 2021
wadamek65
wadamek65 previously approved these changes Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #1044 (749f92a) into master (eafe38e) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
- Coverage   98.98%   98.59%   -0.39%     
==========================================
  Files         202      202              
  Lines        3156     3214      +58     
  Branches      798      829      +31     
==========================================
+ Hits         3124     3169      +45     
- Partials       32       45      +13     
Impacted Files Coverage Δ
packages/uniforms/src/BaseForm.tsx 100.00% <ø> (ø)
packages/uniforms/src/AutoForm.tsx 100.00% <100.00%> (ø)
packages/uniforms/src/QuickForm.tsx 100.00% <100.00%> (ø)
packages/uniforms/src/ValidatedForm.tsx 100.00% <100.00%> (ø)
packages/uniforms-material/src/TextField.tsx 87.50% <0.00%> (-12.50%) ⬇️
packages/uniforms-material/src/NumField.tsx 89.47% <0.00%> (-10.53%) ⬇️
packages/uniforms-material/src/DateField.tsx 91.30% <0.00%> (-8.70%) ⬇️
packages/uniforms-material/src/SubmitField.tsx 93.33% <0.00%> (-6.67%) ⬇️
packages/uniforms-material/src/NestField.tsx 94.11% <0.00%> (-5.89%) ⬇️
packages/uniforms-material/src/ErrorsField.tsx 94.11% <0.00%> (-5.89%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eafe38e...749f92a. Read the comment docs.

@wadamek65 wadamek65 added the Type: Feature New features and feature requests label Oct 6, 2021
@wadamek65 wadamek65 added this to Review in Open Source (migrated) via automation Oct 6, 2021
packages/uniforms/src/AutoForm.tsx Outdated Show resolved Hide resolved
packages/uniforms/src/BaseForm.tsx Show resolved Hide resolved
packages/uniforms/src/QuickForm.tsx Outdated Show resolved Hide resolved
@radekmie radekmie merged commit d57b4a1 into master Oct 28, 2021
Open Source (migrated) automation moved this from Review to Closed Oct 28, 2021
@radekmie radekmie deleted the baseform-getnativeprops branch October 28, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features and feature requests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve BaseForm's getNativeFormProps types
5 participants